This repository was archived by the owner on Feb 28, 2025. It is now read-only.
Prefix Yaml tags with !bson_
#43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
suggested changes
Jan 22, 2024
| 'binary' => new Binary(base64_decode($value)), | ||
| 'bson_regex' => new Regex(...(array) $value), | ||
| 'bson_long' => new Int64($value), | ||
| 'bson_double' => new Decimal128($value), |
There was a problem hiding this comment.
If we're prefixing these with bson_, can we use the actual names for clarity?
That would be bson_int64 above, bson_decimal128 here, and bson_utcdatetime below.
There was a problem hiding this comment.
Are this names shared with other drivers ? The idea is also that this config files could be extracted and used by other languages to create agg builders.
There was a problem hiding this comment.
These names are consistent with the BSON spec, which pre-dates any driver specs. That's the reason we chose the names when implementing ext-mongodb (vs. keeping what we originally had in ext-mongo).
jmikola
approved these changes
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After @jmikola's comment: #37 (comment)