PHPLIB-1358 Add tests on Type Expression Operators #49
Conversation
| /** | ||
| * Test $toDouble expression | ||
| */ | ||
| class ToDoubleOperatorTest extends PipelineTestCase |
There was a problem hiding this comment.
This is outside the scope of the PR, but why does the parameter type for ToDoubleOperator::__construct() include non-empty-string instead of just string? In toDouble.yaml, the $expression argument has a type expression.
I traced this to a "strings cannot be empty" comment in OperatorGenerator::getAcceptedTypes(), but it's unclear to me why that is. That's also the case for StrLenBytesOperator, which I'd expect would be able to take a string of any length.
There was a problem hiding this comment.
Out of zeal, I've put this type for all the strings, but that's probably overkill.
There was a problem hiding this comment.
I feel like there would be at least some cases where an empty string is a legitimate argument for some operators. If you agree, consider opening a separate issue to investigate that at a later point.
Fix PHPLIB-1358
https://www.mongodb.com/docs/manual/reference/operator/aggregation/#type-expression-operators
$convert$isNumberfixed, as it get a single value$toBool$toDate$toDecimal$toDouble$toInt$toLong$toObjectId$toString$type