This repository was archived by the owner on Feb 28, 2025. It is now read-only.
PHPLIB-1362 Add tests on Window Operators #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jan 24, 2024
Comment on lines
+29
to
+31
| denseRankOrderDateForState: Accumulator::outputWindow( | ||
| Accumulator::denseRank(), | ||
| ), |
There was a problem hiding this comment.
The outputWindow is optional when no window property is set. I omitted it in the next test.
There was a problem hiding this comment.
Added this note as a comment in the code.
alcaeus
approved these changes
Jan 26, 2024
| output: object( | ||
| expMovingAvgForStock: Accumulator::expMovingAvg( | ||
| input: Expression::numberFieldPath('price'), | ||
| N: 2, |
There was a problem hiding this comment.
I noted that $expMovingAvg indeed uses an uppercase single-letter parameter name. I'm sure that won't be confusing for people. No need to do something about this now, but I can see ourselves adding some kind of fallback for folks that aren't used to this and use n out of habit.
There was a problem hiding this comment.
PHP is case-insensible for method names but not for property or argument names. Static analysis and PHP error will help:
Fatal error: Uncaught Error: Unknown named parameter $n
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1362
https://www.mongodb.com/docs/manual/reference/operator/aggregation/#window-operators
$addToSet$avg$bottom$bottomN$count$covariancePop$covarianceSamp$denseRank$derivative$documentNumber$expMovingAvg$first$integral$last$linearFill$locf$max$min$minN$push$rank$shift$stdDevPop$stdDevSamp$sum$top$topNI moved some operators from Expression to Accumulator.