This repository was archived by the owner on Feb 28, 2025. It is now read-only.
PHPLIB-1341 Add tests on Miscellaneous Query Operators #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jan 24, 2024
| $pipeline = new Pipeline( | ||
| Stage::match( | ||
| Query::comment('Don\'t allow negative inputs.'), | ||
| x: Query::gt(0), |
There was a problem hiding this comment.
Named arguments must be after positional arguments, even when we use variadic.
jmikola
approved these changes
Jan 26, 2024
| @@ -124,7 +124,7 @@ <h1>Convert JS examples into Yaml</h1> | |||
| case 'boolean': | |||
| return object ? ' true' : ' false'; | |||
| case 'string': | |||
| return " '" + object.replace(/'/g, "\\'") + "'"; | |||
| return " '" + object.replace(/'/g, "''") + "'"; | |||
There was a problem hiding this comment.
Is this necessary for the single-quoted style being used above?
| $match: | ||
| x: | ||
| $gt: 0 | ||
| $comment: 'Don''t allow negative inputs.' |
There was a problem hiding this comment.
Noted that this syntax is specific to Single-Quoted Style. Would it make more sense to use a Double-Quoted Style and avoid escaping altogether, or did you prefer single-quoted for consistency?
There was a problem hiding this comment.
I use single quotes everywhere to avoid risky parsing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1341
https://www.mongodb.com/docs/manual/reference/operator/query/#miscellaneous-operators
$comment$rand