This repository was archived by the owner on Feb 28, 2025. It is now read-only.
Allow to merge an array of stages into a pipeline #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
merge-pipeline-array
branch
from
e383f5c to
a43469a
Compare
alcaeus
previously approved these changes
Jan 29, 2024
| @@ -36,7 +39,9 @@ public function __construct(StageInterface|Pipeline ...$stagesOrPipelines) | |||
| $stages = []; | |||
|
|
|||
| foreach ($stagesOrPipelines as $stageOrPipeline) { | |||
| if ($stageOrPipeline instanceof Pipeline) { | |||
| if (is_array($stageOrPipeline) && array_is_list($stageOrPipeline)) { | |||
There was a problem hiding this comment.
I noticed you don't check whether each item in the list is a StageInterface instance. In theory, this should be fine as PipelineEncoder uses encodeIfSupported to encode each stage. Anything the encoder can't handle will be sent to the server as is, potentially causing an execution error later. This would allow users to inject raw pipeline stages (e.g. if they want to use something not supported by their builder version) as long as they know what they are doing.
GromNaN
force-pushed
the
merge-pipeline-array
branch
from
a43469a to
80a35cd
Compare
GromNaN
force-pushed
the
merge-pipeline-array
branch
from
9b96cc9 to
0850040
Compare
alcaeus
approved these changes
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from https://github.com/mongodb/mongo-php-builder/pull/56/files#r1466461225
I feel that a list of stages is a valid type for a pipeline. We already allowed merging
Pipelineobjects, we can make things more efficient by avoiding the intermediate Pipeline object when we already have an array.