Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

PHPLIB-1384: Use default value in Query::exists() #60

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Feb 2, 2024

PHPLIB-1384

I decided to add another test to explicitly test using exists with a different value.

@alcaeus alcaeus requested a review from GromNaN February 2, 2024 08:40
@alcaeus alcaeus self-assigned this Feb 2, 2024
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with keeping the explicit Query::exists(true) in some tests, but we should have static analysis warnings for setting the default argument value.

price: Query::exists(true),

transaction: Query::exists(true),

@alcaeus alcaeus merged commit 592b0a0 into mongodb:0.1 Feb 2, 2024
@alcaeus alcaeus deleted the phplib-1384-exists-default-value branch February 2, 2024 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants