This repository was archived by the owner on Feb 28, 2025. It is now read-only.
PHPLIB-1273: Improve $switch syntax #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Feb 2, 2024
| @@ -0,0 +1,21 @@ | |||
| # $schema: ../schema.json | |||
| name: $case | |||
| link: 'https://www.mongodb.com/docs/manual/reference/operator/aggregation/switch/' | |||
There was a problem hiding this comment.
I see the interest of creating this "fake" operator for code generation. It should be consistent with OutputWindow this is the same need.
Could you create accumulator/outputWindow.yaml also?
There was a problem hiding this comment.
I'll do so in a separate PR: the current OutputWindow type contains additional validation logic that we can't represent through the config.
alcaeus
force-pushed
the
phplib-1273-switch-syntax
branch
from
9804f17 to
745eef4
Compare
GromNaN
reviewed
Feb 2, 2024
Updated |
alcaeus
force-pushed
the
phplib-1273-switch-syntax
branch
from
0fef6aa to
a80cdf7
Compare
GromNaN
approved these changes
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-1273
Instead of using
object, there is now a dedicatedcaseoperator. In order to accommodate the different encoding forcase, I added aflat_objectencoding mechanism that doesn't wrap the parameter object in another object containing the operator name. Alternatively, we could create a separate encoder forcase.