This repository was archived by the owner on Feb 28, 2025. It is now read-only.
PHPLIB-1367 Add enum for System variables #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Feb 16, 2024
GromNaN
commented
Feb 16, 2024
| * CURRENT is modifiable. However, since $<field> is equivalent to $$CURRENT.<field>, rebinding | ||
| * CURRENT changes the meaning of $ accesses. | ||
| */ | ||
| public static function current(string $fieldPath = ''): ResolvesToAny |
There was a problem hiding this comment.
This helper was more explicit than the new Variable::Current->dot(...) function in introduced to the enum.
| @@ -38,7 +39,7 @@ public function testRemoveFieldsThatContainPeriods(): void | |||
| Stage::replaceWith( | |||
| Expression::unsetField( | |||
| field: 'price.usd', | |||
| input: Expression::variable('ROOT'), | |||
| input: Variable::Root, | |||
There was a problem hiding this comment.
This could have been Variable::root(), which is as good as the enum Variable::Root.
|
Closing for now. Lets revisit later. Ticket still open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1367
Includes #63 (to be merged before)
I originally created factories for system variables, but we can also use enums. I'm not sure what's the best approach. They are almost the same for DX