This repository was archived by the owner on Feb 1, 2022. It is now read-only.
PHP-1431: Fix database name validation to include '$external', to allow execution of user admin commands #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* We allow the special case "$external" as database name (PHP-1431) */ | ||
| if (strcmp("$external", dbname) == 0) { | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
It would be more concise to just move this special case above the preceding character checks. That would eliminate the diff to the character check if block and remove second conditional below (also keeping the exception for "$" characters consistent).
There was a problem hiding this comment.
I had it that way at first, but then decided against it. I can't remember why though... so I've changed it back.
…ow execution of user admin commands
derickr
force-pushed
the
PHP-1431-database-external
branch
from
22a0ee9 to
b806eb5
Compare
|
LGTM. |
derickr
added a commit
that referenced
this pull request
Apr 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.