Skip to content

Commit 1c533ff

Browse files
authored
PHPC-2302: Update build configs for renamed libmongoc substitutions (#1475)
Bumps libmongoc to 1.25-dev
1 parent 7ccb094 commit 1c533ff

File tree

4 files changed

+20
-35
lines changed

4 files changed

+20
-35
lines changed

config.w32

Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,12 @@ function mongodb_generate_header(inpath, outpath, replacements)
2323
outfile.Close();
2424
}
2525

26-
/* TODO: Consolidate these parsing functions once the libbson and libmongoc
27-
* substitutions become consistent again. */
28-
function mongodb_parse_libbson_version_file(inpath)
26+
function mongodb_parse_libmongoc_version_file(prefix)
2927
{
30-
var infile = FSO.OpenTextFile(inpath, 1);
28+
var infile = FSO.OpenTextFile(configure_module_dirname + "/src/LIBMONGOC_VERSION_CURRENT", 1);
3129
var version = infile.ReadLine();
3230
infile.Close();
3331

34-
var prefix = "libbson_";
3532
var xyz_pre = version.split("-");
3633
var xyz = xyz_pre[0].split(".");
3734
var pre = xyz_pre.length > 1 ? xyz_pre[1] : "";
@@ -46,24 +43,13 @@ function mongodb_parse_libbson_version_file(inpath)
4643
return replacements;
4744
}
4845

49-
function mongodb_parse_version_file(inpath, prefix)
46+
function mongodb_get_libmongocrypt_version()
5047
{
51-
var infile = FSO.OpenTextFile(inpath, 1);
48+
var infile = FSO.OpenTextFile(configure_module_dirname + "/src/LIBMONGOCRYPT_VERSION_CURRENT", 1);
5249
var version = infile.ReadLine();
5350
infile.Close();
5451

55-
var xyz_pre = version.split("-");
56-
var xyz = xyz_pre[0].split(".");
57-
var pre = xyz_pre.length > 1 ? xyz_pre[1] : "";
58-
59-
var replacements = {};
60-
replacements[prefix + "VERSION"] = version;
61-
replacements[prefix + "MAJOR_VERSION"] = xyz[0];
62-
replacements[prefix + "MINOR_VERSION"] = xyz[1];
63-
replacements[prefix + "MICRO_VERSION"] = xyz[2];
64-
replacements[prefix + "PRERELEASE_VERSION"] = pre;
65-
66-
return replacements;
52+
return version;
6753
}
6854

6955
function create_folder_recursive(path)
@@ -193,7 +179,7 @@ if (PHP_MONGODB != "no") {
193179
mongodb_generate_header(
194180
configure_module_dirname + "/src/libmongoc/src/libbson/src/bson/bson-version.h.in",
195181
configure_module_dirname + "/src/libmongoc/src/libbson/src/bson/bson-version.h",
196-
mongodb_parse_libbson_version_file(configure_module_dirname + "/src/LIBMONGOC_VERSION_CURRENT")
182+
mongodb_parse_libmongoc_version_file("libbson_")
197183
);
198184

199185
var mongoc_opts = {
@@ -332,8 +318,7 @@ if (PHP_MONGODB != "no") {
332318
MONGODB_ADD_SOURCES("/src/libmongocrypt/src/os_win", PHP_MONGODB_MONGOCRYPT_OS_WIN_SOURCES);
333319
MONGODB_ADD_SOURCES("/src/libmongocrypt/kms-message/src", PHP_MONGODB_MONGOCRYPT_KMS_MESSAGE_SOURCES);
334320

335-
var mongocrypt_version = mongodb_parse_version_file(configure_module_dirname + "/src/LIBMONGOCRYPT_VERSION_CURRENT", "")
336-
mongocrypt_opts.MONGOCRYPT_BUILD_VERSION = mongocrypt_version.VERSION;
321+
mongocrypt_opts.MONGOCRYPT_BUILD_VERSION = mongodb_get_libmongocrypt_version();
337322

338323
mongodb_generate_header(
339324
configure_module_dirname + "/src/libmongocrypt/src/mongocrypt-config.h.in",
@@ -383,6 +368,6 @@ if (PHP_MONGODB != "no") {
383368
mongodb_generate_header(
384369
configure_module_dirname + "/src/libmongoc/src/libmongoc/src/mongoc/mongoc-version.h.in",
385370
configure_module_dirname + "/src/libmongoc/src/libmongoc/src/mongoc/mongoc-version.h",
386-
mongodb_parse_version_file(configure_module_dirname + "/src/LIBMONGOC_VERSION_CURRENT", "MONGOC_")
371+
mongodb_parse_libmongoc_version_file("libmongoc_")
387372
);
388373
}
Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
MONGOC_CURRENT_FILE=[]PHP_EXT_SRCDIR(mongodb)[/src/LIBMONGOC_VERSION_CURRENT]
2-
MONGOC_VERSION=$(cat $MONGOC_CURRENT_FILE)
2+
libmongoc_VERSION_FULL=$(cat $MONGOC_CURRENT_FILE)
33

44
dnl Ensure newline for "cut" implementations that need it, e.g. HP-UX.
5-
MONGOC_MAJOR_VERSION=$( (cat $MONGOC_CURRENT_FILE; echo) | cut -d- -f1 | cut -d. -f1 )
6-
MONGOC_MINOR_VERSION=$( (cat $MONGOC_CURRENT_FILE; echo) | cut -d- -f1 | cut -d. -f2 )
7-
MONGOC_MICRO_VERSION=$( (cat $MONGOC_CURRENT_FILE; echo) | cut -d- -f1 | cut -d. -f3 )
8-
MONGOC_PRERELEASE_VERSION=$(cut -s -d- -f2 $MONGOC_CURRENT_FILE)
5+
libmongoc_VERSION_MAJOR=$( (cat $MONGOC_CURRENT_FILE; echo) | cut -d- -f1 | cut -d. -f1 )
6+
libmongoc_VERSION_MINOR=$( (cat $MONGOC_CURRENT_FILE; echo) | cut -d- -f1 | cut -d. -f2 )
7+
libmongoc_VERSION_PATCH=$( (cat $MONGOC_CURRENT_FILE; echo) | cut -d- -f1 | cut -d. -f3 )
8+
libmongoc_VERSION_PRERELEASE=$(cut -s -d- -f2 $MONGOC_CURRENT_FILE)
99

10-
AC_SUBST(MONGOC_VERSION)
11-
AC_SUBST(MONGOC_MAJOR_VERSION)
12-
AC_SUBST(MONGOC_MINOR_VERSION)
13-
AC_SUBST(MONGOC_MICRO_VERSION)
14-
AC_SUBST(MONGOC_PRERELEASE_VERSION)
10+
AC_SUBST(libmongoc_VERSION_FULL)
11+
AC_SUBST(libmongoc_VERSION_MAJOR)
12+
AC_SUBST(libmongoc_VERSION_MINOR)
13+
AC_SUBST(libmongoc_VERSION_PATCH)
14+
AC_SUBST(libmongoc_VERSION_PRERELEASE)

src/LIBMONGOC_VERSION_CURRENT

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.25.0-20230922+git1c8da0ee19
1+
1.25.0-20230926+git06b23c4563

0 commit comments

Comments
 (0)