PHPC-2302: Update build configs for renamed libmongoc substitutions #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps libmongoc to 1.25-dev
jmikola
commented
Sep 26, 2023
| @@ -46,24 +43,13 @@ function mongodb_parse_libbson_version_file(inpath) | |||
| return replacements; | |||
| } | |||
|
|
|||
| function mongodb_parse_version_file(inpath, prefix) | |||
| function mongodb_get_libmongocrypt_version() | |||
There was a problem hiding this comment.
Changed this function to just return the string needed for MONGOCRYPT_BUILD_VERSION: https://github.com/mongodb/libmongocrypt/blob/40cc4eea42028e5cdf907b996d36aa2187c08441/src/mongocrypt-config.h.in#L22-L27
alcaeus
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2302
Bumps libmongoc to 1.25-dev
Related to #1474