PHPC-1369: Upgrade libmongoc to 1.15.0 #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
changed the title
alcaeus
force-pushed
the
phpc-1422
branch
2 times, most recently
from
0af97cd to
3c00ce6
Compare
jmikola
reviewed
Aug 19, 2019
|
When upgrading the libmongoc submodule, be sure to regenerate Perhaps we should also reference this outside of the "Releasing" section, as that may be how you missed it. |
…ue to using an unsupported storage engine
I looked at #996 and tried to replicate your steps, but I definitely missed this. I expanded the contribution docs to include a section on bumping libmongoc and moved the highlighted paragraph from the release docs to this new chapter since we not only bump libmongoc during release preparations. |
jmikola
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1369
Also contains a test to verify the actionable exception message when using retryWrites on a storage engine that doesn't support it (PHPC-1422) as well as two sanity tests to test retryable reads (PHPC-1291). Spec tests for retryable reads will be implemented in PHPLIB-463.