PHPC-1073: Remove superfluous calls to php_array_exists #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Oct 15, 2019
| upsert = php_array_fetchc_bool(zoptions, "upsert"); | ||
| } | ||
| multi = php_array_fetchc_bool(zoptions, "multi"); | ||
| upsert = php_array_fetchc_bool(zoptions, "upsert"); |
There was a problem hiding this comment.
PHPC-1073 mentions that bool fetching might still want "exists" checks, but I assume this is fine since both default to false already, correct?
Likewise for any bool fetches later on in this PR where false corresponds to the default case.
There was a problem hiding this comment.
That is correct. Looking at php_array_fetchc_bool, it returns false if the option isn't given. Since these two are false by default, we don't need to check for the existence of it. When we have a bool that is true by default, we need to check for existence first so we can default to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1073