Skip to content

PHPC-1445: Make find commands for collecting sources portable #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

PHPC-1445: Make find commands for collecting sources portable #1064

merged 1 commit into from
Nov 28, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Nov 26, 2019

@alcaeus alcaeus requested a review from jmikola November 26, 2019 12:01
@alcaeus alcaeus self-assigned this Nov 26, 2019
jmikola
jmikola reviewed Nov 26, 2019
View reviewed changes
@alcaeus
Copy link
Member Author

alcaeus commented Nov 27, 2019

@jmikola While re-checking the sorting you pointed out above, I noticed that this needed another change.

The problem is that the regular cut program on MacOS does not understand the z flag to cut along a zero byte. Installing coreutils and using gcut solves this, but is no longer portable. I've added a note to both config.m4 and config.w32 to use gcut on MacOS, either by changing the command before invoking or by symlinking cut to invoke gcut. The sort order can be made consistent by using the d option as indicated above.

@alcaeus alcaeus requested a review from jmikola November 27, 2019 06:39
@alcaeus alcaeus changed the title PHPC-1445: Use gcut to make find commands for collecting sources portable PHPC-1445: Make find commands for collecting sources portable Nov 27, 2019
alcaeus added a commit that referenced this pull request Nov 28, 2019
@alcaeus
Merge pull request #1064
de20fe2
@alcaeus alcaeus merged commit 7c588f4 into mongodb:master Nov 28, 2019
@alcaeus alcaeus deleted the phpc-1445 branch November 28, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees

@alcaeus alcaeus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @jmikola