Skip to content

PHPC-1499: Add clientEncryption API #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 22, 2020
Merged

PHPC-1499: Add clientEncryption API #1075

merged 8 commits into from
Jan 22, 2020

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Dec 20, 2019 •
edited
Loading

@alcaeus alcaeus requested a review from jmikola December 20, 2019 16:19
@alcaeus alcaeus self-assigned this Dec 20, 2019
@alcaeus alcaeus force-pushed the phpc-1499 branch 6 times, most recently from 8a711df to e11ad0e Compare January 16, 2020 09:19
@alcaeus
Copy link
Member Author

alcaeus commented Jan 16, 2020

@jmikola PR rebased to bring in changes from #1071. I've also added a build to test the driver compiled without support FLE - this helped uncover some missing symbols I had in this PR before. This is good to review now 👍

jmikola
jmikola reviewed Jan 17, 2020
View reviewed changes
@alcaeus alcaeus force-pushed the phpc-1499 branch 3 times, most recently from b07005a to c252b51 Compare January 17, 2020 12:50
jmikola
jmikola reviewed Jan 20, 2020
View reviewed changes
@alcaeus alcaeus force-pushed the phpc-1499 branch 4 times, most recently from 84c060d to 801f13d Compare January 20, 2020 12:12
jmikola
jmikola approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to add a clientencryption-constants.phpt test, but LGTM otherwise. Good job!

alcaeus added a commit that referenced this pull request Jan 22, 2020
@alcaeus
Merge pull request #1075
99e8362
@alcaeus alcaeus merged commit c54bbaa into mongodb:master Jan 22, 2020
@alcaeus alcaeus deleted the phpc-1499 branch January 22, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees

@alcaeus alcaeus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @jmikola