PHPC-1496: Use https URL for libmongocrypt submodule #1082
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
referenced
this pull request
Jan 16, 2020
I think we can remove that, yes.
Yes, that can stay, and we can add that to the libmongocrypt submodule while we're at it. That avoids git showing untracked files as changed, which also happens while compiling PHPC with libmongocrypt. |
Also removes obsolete branch option for libmongoc and adds ignore option for libmongocrypt.
alcaeus
approved these changes
Jan 20, 2020
alcaeus
added a commit
that referenced
this pull request
Jan 20, 2020
|
Merged manually in 7b7f53f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: 7cea21a#r36836787
@alcaeus Separate question while we're modifying this file. The
branchvalue for libmongoc looks quite outdated. Should we just remove that while we're at it?I'm not familiar with the
ignoreoption, but this thread suggests it's useful for suppressing some git output. I suppose that's worth keeping since developers on PHPC tend to modify libmongoc sources from time to time.