Skip to content

PHPC-1442: Drop support for PHP 5.6 #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 11, 2020
Merged

PHPC-1442: Drop support for PHP 5.6 #1096

merged 10 commits into from
Feb 11, 2020

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Feb 4, 2020

@alcaeus alcaeus requested a review from jmikola February 4, 2020 18:51
@alcaeus alcaeus self-assigned this Feb 4, 2020
@alcaeus
Copy link
Member Author

alcaeus commented Feb 10, 2020

@jmikola dropped all compat macros that are now useless. I recommend looking at the diff commit by commit as the changeset got a lot larger.

@alcaeus alcaeus requested a review from jmikola February 10, 2020 09:15
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about casting for efree() which might warrant a change. LGTM otherwise!

FWIW, I did not bother to review the commit removing the TSRM macros 😅

alcaeus added a commit that referenced this pull request Feb 11, 2020
@alcaeus alcaeus merged commit 58011a5 into mongodb:master Feb 11, 2020
@alcaeus alcaeus deleted the phpc-1442 branch February 11, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants