-
Notifications
You must be signed in to change notification settings - Fork 208
PHPC-1442: Drop support for PHP 5.6 #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jmikola dropped all compat macros that are now useless. I recommend looking at the diff commit by commit as the changeset got a lot larger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about casting for efree()
which might warrant a change. LGTM otherwise!
FWIW, I did not bother to review the commit removing the TSRM macros 😅
https://jira.mongodb.org/browse/PHPC-1442