Skip to content

Update libmongoc to 1.17.0-dev #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Feb 7, 2020

Takes care of PHPC-1440 and PHPC-1478. SCRAM is entirely done in libmongoc, so no changes are necessary on our side to support the shorter conversation.

@alcaeus alcaeus requested a review from jmikola February 7, 2020 08:35
@alcaeus alcaeus self-assigned this Feb 7, 2020
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change for commented bit in the Evergreen config, but LGTM otherwise.

display_name: "1.16 latest"
variables:
LIBMONGOC_VERSION: "r1.16"
# Todo: re-enable once 1.17 is branches
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"is branched"

Also, perhaps you want to pre-emptively update the references to "1.16" below?

alcaeus added a commit that referenced this pull request Feb 10, 2020
@alcaeus
Copy link
Member Author

alcaeus commented Feb 10, 2020

Manually merged in fcc053f.

@alcaeus alcaeus closed this Feb 10, 2020
@alcaeus alcaeus deleted the phpc-1478 branch February 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants