Automatically detect PHP patch version #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Feb 17, 2021
| @@ -92,8 +107,10 @@ functions: | |||
| export PROJECT_DIRECTORY="$PROJECT_DIRECTORY" | |||
|
|
|||
| export TMPDIR="$MONGO_ORCHESTRATION_HOME/db" | |||
| export PATH="$MONGODB_BINARIES:$PATH" | |||
| export PATH="$PHP_PATH:$MONGODB_BINARIES:$PATH" | |||
There was a problem hiding this comment.
This allows you to remove the PATH concatenation in compile-unix.sh, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the evergreen build config to no longer set a specific patch version for PHP, instead only setting the minor version to be used (e.g. "7.4"). This reduces the workload associated with updating the PHP toolchain, since we no longer need to update the evergreen config when the toolchain brings new patch releases for PHP. The path to PHP binaries is now also prepended to the
PATHenvironment variable.The script will attempt to fetch the latest patch version for the requested PHP version (by using the version sort functionality of
sort) and error if none was found. The logic will need adjusting if we want to start testing against thread-safe versions of PHP.These changes will be ported to the PHPLIB evergreen config once they've been merged here.