Skip to content

PHPC-1801: Fix arginfo for Manager::selectServer #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

PHPC-1801: Fix arginfo for Manager::selectServer #1211

merged 1 commit into from
Mar 31, 2021

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Mar 30, 2021

@jmikola jmikola requested a review from alcaeus March 30, 2021 20:07
@jmikola jmikola changed the base branch from master to v1.9 March 30, 2021 20:07
@jmikola
Copy link
Member Author

jmikola commented Mar 30, 2021

@alcaeus is the v1.9 branch still expected to fail Evergreen due to RS tags (see: build log). Oddly, this wasn't reported in the CI feedback above. I happened to receive a separate Evergreen notification about the build failing.

@alcaeus
Copy link
Member

alcaeus commented Mar 31, 2021

@alcaeus is the v1.9 branch still expected to fail Evergreen due to RS tags (see: build log). Oddly, this wasn't reported in the CI feedback above

Yes, evergreen only runs on pull requests targeting the master branch, and I made the mistake of targeting master with #1206. I'll cherry-pick the resulting commit into v1.9 to ensure patch builds are stable as well. Thanks for pointing this out.

alcaeus
alcaeus approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to have this automatically generated from PHP class stubs...

@jmikola jmikola merged commit 5d3e616 into v1.9 Mar 31, 2021
@jmikola jmikola deleted the phpc-1801 branch March 31, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikola @alcaeus