PHPC-1835: Rotate credentials for Atlas connectivity tests #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
May 10, 2021
| @@ -32,16 +38,22 @@ foreach ($urls as $url) { | |||
| ===DONE=== | |||
| <?php exit(0); ?> | |||
| --EXPECTF-- | |||
| Atlas replica set (3.4) | |||
There was a problem hiding this comment.
FYI, the URI file now has the following format:
# Atlas replica set (3.4)
mongodb://user:pass@...
mongodb+srv://user:pass@...
# Atlas sharded cluster (3.4)
mongodb://user:pass@...
mongodb+srv://user:pass@...
# Atlas free tier replica set (4.4)
mongodb://user:pass@...
mongodb+srv://user:pass@...
# Atlas with only TLSv1.1 enabled (3.4)
mongodb://user:pass@...
mongodb+srv://user:pass@...
# Atlas with only TLSv1.2 enabled (3.4)
mongodb://user:pass@...
mongodb+srv://user:pass@...
# Atlas with only TLSv1.2 enabled (3.4) and bad credentials
mongodb://user:INVALID@...
mongodb+srv://user:INVALID@...
There was a problem hiding this comment.
That explains the trim you introduced above. Thanks!
alcaeus
approved these changes
May 11, 2021
| @@ -32,16 +38,22 @@ foreach ($urls as $url) { | |||
| ===DONE=== | |||
| <?php exit(0); ?> | |||
| --EXPECTF-- | |||
| Atlas replica set (3.4) | |||
There was a problem hiding this comment.
That explains the trim you introduced above. Thanks!
This corresponds with a change to the project's Evergreen config to rotate keys for decrypting atlas-uris.txt.enc. Additionally, this adds comments atlas-uris.txt and atlas.phpt test output for improved readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing tests may be blocked on fixing expired certificates in cloud-dev, per the related HELP ticket in PHPC-1835.
This PR corresponds with a change to the Evergreen project config to rotate the vars used for decrypting the URI file.