Skip to content

PHPC-1765 and PHPC-1821: DBRef and dot/dollar validation tests #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jun 4, 2021

@jmikola jmikola requested a review from alcaeus June 4, 2021 20:50
@jmikola jmikola force-pushed the phpc-1821 branch 2 times, most recently from 609eb44 to 41e2a6c Compare June 21, 2021 19:38
@jmikola jmikola changed the title [WAIT] PHPC-1821: Bump libmongoc for DBRef handling changes [WAIT] PHPC-1765 and PHPC-1821: Bump libmongoc for DBRef and dot/dollar validation Jun 21, 2021
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmikola jmikola force-pushed the phpc-1821 branch 2 times, most recently from 29e9973 to a0bcc55 Compare June 22, 2021 18:39
Remove tests expecting client-side validation errors for dots/dollars in field names.

Syncs BSON corpus tests with mongodb/specifications@a274fbf
@jmikola jmikola changed the title [WAIT] PHPC-1765 and PHPC-1821: Bump libmongoc for DBRef and dot/dollar validation PHPC-1765 and PHPC-1821: Bump libmongoc for DBRef and dot/dollar validation Jun 22, 2021
@jmikola jmikola changed the title PHPC-1765 and PHPC-1821: Bump libmongoc for DBRef and dot/dollar validation PHPC-1765 and PHPC-1821: DBRef and dot/dollar validation tests Jun 22, 2021
@jmikola jmikola merged commit 6929bcb into mongodb:master Jun 22, 2021
@jmikola jmikola deleted the phpc-1821 branch June 22, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants