Skip to content

PHPC-1922 Update PHONGO_CE_DISABLE_SERIALIZATION for PHP 8.1 #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

remicollet
Copy link
Contributor

From UPGRADING.INTERNALS

 f. Non-serializable classes should be indicated using the
     ZEND_ACC_NOT_SERIALIZABLE (@not-serializable in stubs) rather than the
     zend_class_(un)serialize_deny handlers which are removed.

@remicollet
Copy link
Contributor Author

Looks like 8.1 failure is related to outdated version available (some alpha) as the change is for 8.1.0beta1

@alcaeus alcaeus self-requested a review July 23, 2021 18:15
@alcaeus
Copy link
Member

alcaeus commented Jul 23, 2021

@remicollet thanks for the patch. I'll take a look after the weekend and see where I need to kick the build to fix it

@jmikola
Copy link
Member

jmikola commented Jul 26, 2021

Note: this may be related to PHPC-1849, although that pertains to the Serializable interface. We may want a new ticket for this PR, which can be added to the same epic for 8.1 support.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally on PHP 8.1, we'll figure out the 8.1 build environment when we pick up PHPC-1850. I've also created PHPC-1922 to track this.

@alcaeus alcaeus changed the title Fix API change in 8.1.0beta1 PHPC-1922 Update PHONGO_CE_DISABLE_SERIALIZATION for PHP 8.1 Jul 27, 2021
@alcaeus alcaeus merged commit 5d7796b into mongodb:master Jul 27, 2021
@alcaeus
Copy link
Member

alcaeus commented Jul 27, 2021

Thanks @remicollet!

@remicollet remicollet deleted the issue-php81b1 branch July 27, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants