PHPC-1925: Change ServerDescription::getType() to return a string #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Aug 17, 2021
| @@ -115,7 +125,7 @@ static PHP_METHOD(ServerDescription, getType) | |||
|
|
|||
| PHONGO_PARSE_PARAMETERS_NONE(); | |||
|
|
|||
| RETVAL_LONG(php_phongo_server_description_type(intern->server_description)); | |||
| RETVAL_STRING(mongoc_server_description_type(intern->server_description)); | |||
There was a problem hiding this comment.
This would be a good opportunity to revise serverDescription-getType-001.phpt similar to what you did for the TopologyDescription::getType() test.
Additionally, php_phongo_serverdescription_get_properties_hash can be changed to output a "type" as a string instead of calling php_phongo_server_description_type. Its test can also be revised to use %r like the corresponding TopologyDescription tests.
|
According to CI, |
|
Yes sorry, I saw but didn't have time to finish yesterday |
|
No worries. I wasn't sure if you caught it since it was after the review was requested. |
jmikola
approved these changes
Aug 18, 2021
jmikola
pushed a commit
that referenced
this pull request
Nov 3, 2021
jmikola
pushed a commit
that referenced
this pull request
Dec 30, 2021
jmikola
pushed a commit
that referenced
this pull request
Jan 5, 2022
jmikola
pushed a commit
to jmikola/mongo-php-driver
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1925