PHPC-1965 Re-enable PHP 8.1 build on GH Actions #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
enable-php81-build
branch
from
13cec46 to
133e9ba
Compare
alcaeus
changed the title
alcaeus
force-pushed
the
enable-php81-build
branch
from
133e9ba to
5aafc35
Compare
alcaeus
force-pushed
the
enable-php81-build
branch
from
5aafc35 to
c8b8e4d
Compare
alcaeus
force-pushed
the
enable-php81-build
branch
from
c8b8e4d to
c0dbf15
Compare
jmikola
approved these changes
Sep 3, 2021
| Before: | ||
| array(2) refcount(2){ | ||
| ["root"]=> | ||
| reference refcount(1) { |
There was a problem hiding this comment.
Noted that this pertains to php/php-src#6750.
This is much more useful output than pre-8.1. Very nice.
| @@ -9,4 +9,4 @@ class MyBinary extends MongoDB\BSON\Binary {} | |||
| ===DONE=== | |||
| <?php exit(0); ?> | |||
| --EXPECTF-- | |||
| Fatal error: Class MyBinary may not inherit from final class (MongoDB\BSON\Binary) in %s on line %d | |||
| Fatal error: Class MyBinary %s final class %SMongoDB\BSON\Binary%S in %s on line %d | |||
There was a problem hiding this comment.
Noted that this pertains to php/php-src#7307.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-1965