PHPC-1997: Migrate to new libbson atomic API #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Nov 5, 2021
| @@ -3789,7 +3789,7 @@ PHP_GSHUTDOWN_FUNCTION(mongodb) | |||
| * is the last thread, MSHUTDOWN has been called, persistent clients from | |||
| * all threads have been destroyed, and it is now safe to shutdown libmongoc | |||
| * and restore libbson's original vtable. */ | |||
| if (bson_atomic_int_add(&phongo_num_threads, -1) == 0) { | |||
| if (bson_atomic_int32_fetch_sub(&phongo_num_threads, 1, bson_memory_order_seq_cst) - 1 == 0) { | |||
There was a problem hiding this comment.
@vector-of-bool: Would you mind sanity-checking these two lines? In the one above, I'm just doing an increment and don't need the return value. Here's we're decrementing and checking the return value, so I believe I need to also subtract from the result since the __atomic_fetch_OP built-ins return the original value (in contrast to __atomic_OP_fetch variants).
There was a problem hiding this comment.
This change is correct: The value returned will be the value from before the operation completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1997