PHPC-2200: Add MongoDB rapid releases to Evergreen matrix #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Apr 5, 2023
| variables: | ||
| VERSION: "5.0" | ||
| MONGODB_VERSION: "6.0" |
There was a problem hiding this comment.
Thoughts on using "rapid" here?
See also: mongodb/mongo-php-library#1056 (comment)
There was a problem hiding this comment.
Quoting @JamesKovacs from Slack:
When M.0.0 goes GA, rapid points to (M-1).3.x for a quarter, which isn't useful since no one can run that quarterly release
With that in mind, I think keeping 6.0 makes sense here and we can just bump to 7.0 when that gets released.
| display_name: "Load balanced - ${mongodb-versions}" | ||
| exclude_spec: | ||
| # Load balancer is available from MongoDB 5.0+ | ||
| - { "os": "debian11", "mongodb-versions": ["3.6", "4.0", "4.2", "4.4"], "php-edge-versions": "latest-stable" } |
There was a problem hiding this comment.
The test-csfle-skip_crypt_shared matrix below currently use 6.0 exclusively. Let me know if you think it makes sense to test on 6.0+ using an exclude_spec similar to what we have here.
See also: mongodb/mongo-php-library#1056 (comment)
alcaeus
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2200
Related to mongodb/mongo-php-library#1056