Skip to content

Add missing void arg to fix MacOS builds #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Apr 11, 2023

Upgraded to MacOS 13.3 recently and building the driver exposed this failure. Not sure why this didn't appear earlier as strict-prototypes was part of our developer build flags for a long time already.

src/phongo_client.c:78:44: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
const char* php_phongo_crypt_shared_version()

@alcaeus alcaeus requested a review from jmikola April 11, 2023 08:35
@alcaeus alcaeus merged commit 70bdd80 into mongodb:master Apr 12, 2023
@alcaeus alcaeus deleted the fix-mac-build branch April 12, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants