PHPC-2208: Fix fragile assertion on session IDs #1414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2208
A short investigation has led me to conclude that
%cshould definitely match the end-of-line character, as run-tests.php replaces it with a.in the regular expression, which is then matched using thePCRE_DOTALLmodifier. However, since trying to figure this out is inconsequential and the previous fix (applied in #974 to work around PHPC-1345) doesn't work in this case, I replaced the sequence of%cwith a single%aacross the tests. While this may match more or fewer than 16 characters unlike the previous solution, as the debug output also containsstring(16)any binary data that isn't 16 characters long would fail the checks based on that part, apart from being improbable due to the verification employed for BSON subtype 0x04 (UUID).