Skip to content

Fix typo in topologyClosedEvent test comment #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Fix typo in topologyClosedEvent test comment #1456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4adb3ca
Fix typo in topologyClosedEvent test comment
jmikola Aug 7, 2023
ea8931f
Merge branch 'master' into topologyClosedEvent-typo
jmikola Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/apm/topologyClosedEvent-001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class MySubscriber implements MongoDB\Driver\Monitoring\SDAMSubscriber
public function topologyOpening(MongoDB\Driver\Monitoring\TopologyOpeningEvent $event): void {}
}

/* Note: TopologyChangedEvent can only be observed for non-persistent clients.
/* Note: TopologyClosedEvent can only be observed for non-persistent clients.
* Persistent clients are destroyed in GSHUTDOWN, long after any PHP objects
* (including subscribers) are freed. */
$m = create_test_manager(URI, [], ['disableClientPersistence' => true]);
Expand Down