Skip to content

PHPC-2282: Remove trace-level logs during BSON encoding #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2023
Merged

PHPC-2282: Remove trace-level logs during BSON encoding #1465

merged 1 commit into from
Sep 8, 2023

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Sep 6, 2023

@alcaeus alcaeus requested a review from jmikola September 6, 2023 12:43
@alcaeus alcaeus self-assigned this Sep 6, 2023
jmikola
jmikola reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted your comments in Slack that these trace statements had minimal impact on benchmarks. Still, glad to have them removed from both our code and emitted log output.

@alcaeus alcaeus force-pushed the phpc-2282-remove-bson-trace-logs branch from 80d4289 to 7c0d68f Compare September 8, 2023 07:40
@alcaeus alcaeus merged commit 3f39b77 into mongodb:master Sep 8, 2023
@alcaeus alcaeus deleted the phpc-2282-remove-bson-trace-logs branch September 8, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees

@alcaeus alcaeus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @jmikola