Skip to content

PHPC-2337: Fix performance regression due to trace logging #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2023
Merged

PHPC-2337: Fix performance regression due to trace logging #1504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions php_phongo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ PHP_MINIT_FUNCTION(mongodb) /* {{{ */
* a logger. */
mongoc_log_set_handler(NULL, NULL);

/* Disable trace logging. This will be enabled in phongo_log_sync_handlers()
* if the "mongodb.debug" INI option is set. */
mongoc_log_trace_disable();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that MINIT is called before OnUpdateDebug, so this doesn't conflict with tracing enabled via INI files.


phongo_register_ini_entries(INIT_FUNC_ARGS_PASSTHRU);

/* Assign our custom vtable to libbson, so all memory allocation in libbson
Expand Down