-
Notifications
You must be signed in to change notification settings - Fork 208
PHPC-2373 and PHPC-2374: Upgrade libmongoc 1.27.0 and libmongocrypt 1.10.0 #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing changes to the versions in .evergreen/config/templates/build/build-libmongoc.yml.
Windows builds are also throwing errors, so something is wrong on that platform.
I'm discussing Windows build errors in #dbx-c-cxx:
Will follow up once I make some headway on that. |
config.w32 requires an additional include path ("./src/libmongoc/src/libmongoc/src/mongoc") due to usage of angle bracket includes in mcd-nsinfo.c and utlist.h.
/I" + configure_module_dirname + "/src/libmongoc/src/libbson/src \ | ||
/I" + configure_module_dirname + "/src/libmongoc/src/libbson/src/jsonsl \ | ||
/I" + configure_module_dirname + "/src/libmongoc/src/libmongoc/src \ | ||
/I" + configure_module_dirname + "/src/libmongoc/src/libmongoc/src/mongoc \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the suggested workaround for libmongoc using <>
instead of ""
for some new #include
statements introduced in 1.27.0. CI suggests this is only necessary for Windows, but let me know if you think it'd be wise to duplicate this in config.m4
. Alternatively, we can wait and see if any bug reports come in and address this in a patch release if needed (any failure would be quite obvious).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to do this for Windows only at this time 👍
https://jira.mongodb.org/browse/PHPC-2373
https://jira.mongodb.org/browse/PHPC-2374