Skip to content

PHPC-2388: Install VC15 component for PHP 7.4 #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented May 22, 2024

@jmikola jmikola force-pushed the phpc-2388 branch 5 times, most recently from d6326c7 to 0ec4c05 Compare May 23, 2024 14:47
@jmikola jmikola marked this pull request as ready for review May 23, 2024 15:49
@jmikola jmikola requested a review from alcaeus May 23, 2024 15:49
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

I'd say this should target v1.19 in case we need to release a 1.19 patch version.

VC15 was recently removed from the windows-2022 image, so manually reinstall it for PHP 7.4 builds.
@jmikola jmikola changed the base branch from master to v1.19 May 23, 2024 16:03
@jmikola
Copy link
Member Author

jmikola commented May 23, 2024

I'd say this should target v1.19 in case we need to release a 1.19 patch version.

Yup. Thanks for catching that. I did intend to target v1.19 since we'll need this for releasing #1555 in 1.19.1. I missed doing the same for #1557 but that's thankfully wasn't essential.

@jmikola jmikola merged commit 69d4a72 into mongodb:v1.19 May 23, 2024
72 of 73 checks passed
@jmikola jmikola deleted the phpc-2388 branch May 23, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants