PHPC-2398: Use server_id methods for libmongoc 1.28+ #1582
Conversation
Bumps libmongoc to 1.28-dev
There was a problem hiding this comment.
Evergreen config needs regenerating.
Note: I don't think we need to update the SBOM for this change, especially considering that I forgot how nasty the development version info is. It would need some parsing and/or different handling in order to produce a proper purl.
| @@ -11,7 +11,8 @@ tasks: | |||
| - func: "compile driver" | |||
| vars: | |||
| PHP_VERSION: "%phpVersion%" | |||
| LIBMONGOC_VERSION: "1.27.2" | |||
| # TODO: Change to "1.28.0" once 1.28.0 is released | |||
| LIBMONGOC_VERSION: "master" | |||
There was a problem hiding this comment.
This necessitates regenerating the actual build configs.
There was a problem hiding this comment.
Aye, oversight on my part. Just regenerated.
Agreed. I skipped that step from CONTRIBUTING.md and think it makes sense to do so provided we never cut a stable release on a dev version of libmongoc. |
|
Evergreen test failures are related to PHPC-2401, since CDRIVER-4828 has already been completed in libmongoc 1.28-dev. I'll look into this while this PR is open so we can avoid build failures after merging. |
* master: (22 commits) PHPC-2434: Add PHP 8.4 to GitHub Actions (#1625) PHPC-2421, PHPC-2428: Update bundled dependencies (#1622) Don't build libmongoc version in pull requests Use drivers-evergreen-tools for Windows testing (#1615) PHPC-1957 Add tests for out-of-range UTCDateTime values (#1614) PHPC-2286 Implement `UTCDateTime::toDateTimeImmutable` (#1611) PHPC-2414, PHPC-2415: Update wire versions for MongoDB 8.0 compatibility (#1610) PHPC-2349, PHPC-2411: Deprecate unused exception classes (#1608) Fix failing tests on x86 systems (#1609) PHPC-2347: Deprecate BSON functions (#1607) PHPC-1489: Deprecate integer readPreference constants (#1604) Fix version computation for libmongoc development versions (#1599) PHPC-2376: Test against MongoDB 8.0 (#1598) PHPC-2254: Relax server selection timeout error message pattern (#1587) PHPC-2401: Support QEv2 range protocol (#1583) PHPC-2398: Use server_id methods for libmongoc 1.28+ (#1582) PHPC-2395: Fetch Atlas connectivity URIs from AWS Secrets Manager (#1579) Merge v1.19 into master (#1578) Revert "Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568)" (#1571) Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568) ...
https://jira.mongodb.org/browse/PHPC-2398
Bumps libmongoc to 1.28-dev