Reduce amount of evergreen config includes #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
commented
Jul 17, 2024
| @@ -4,7 +4,6 @@ | |||
| # These tasks are used in the build task group "build-php-libmongoc" defined in .evergreen/config/build-task-groups.yml, | |||
| # where the "max_hosts" setting must be set to the number of enabled tasks. | |||
| # Last but not least, make sure the corresponding test variants are enabled in .evergreen/config/test-variants.yml | |||
| tasks: | |||
There was a problem hiding this comment.
I decided to remove the top-level key in all templates to avoid having to use a yaml library to combine individual config files. It's not optimal, but it works for the time being.
There was a problem hiding this comment.
You could also use a regex to remove it. I let you judge what is the less bad for maintenance.
There was a problem hiding this comment.
I think this works fine for the time being - the less I mess with the files the better it is.
GromNaN
approved these changes
Jul 17, 2024
alcaeus
added a commit
that referenced
this pull request
Jul 17, 2024
* v1.19: Reduce amount of evergreen config includes (#1612)
alcaeus
added a commit
that referenced
this pull request
Jul 17, 2024
* v1.19: Reduce amount of evergreen config includes (#1612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per a recent change, we can no longer include more than 35 files in an evergreen config. To work around this, the config generation script now outputs a single file for each template, containing all of the versions instead of separate files for each version.