Skip to content

PHPC-527: Fix PHP 7 / 32bits build #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

PHPC-527: Fix PHP 7 / 32bits build #185

wants to merge 1 commit into from

Conversation

remicollet
Copy link
Contributor 

 /builddir/build/BUILD/php-pecl-mongodb-1.1.1/NTS/src/bson.c: In function 'php_phongo_bson_visit_int64':
 /builddir/build/BUILD/php-pecl-mongodb-1.1.1/NTS/src/bson.c:508:38: error: macro "add_assoc_stringl" passed 5 arguments, but takes just 4
   ADD_ASSOC_INT64(retval, key, v_int64);

As ADD_ASSOC_STRINGL imply string duplicate, also need to free the temp (can perhaps be optimized for PHP 5... but more conditional for a race condition...)

@bjori bjori mentioned this pull request Dec 29, 2015
Closed
jmikola added a commit that referenced this pull request Dec 30, 2015
@jmikola
Merge pull request #185
1f0f79d
@jmikola
Copy link
Member

jmikola commented Dec 30, 2015

Opened PHPC-527 to track this and merged in 1f0f79d. Thank you!

@jmikola jmikola closed this Dec 30, 2015
@jmikola jmikola changed the title Fix PHP 7 / 32bits build PHPC-527: Fix PHP 7 / 32bits build Dec 30, 2015
@remicollet remicollet mentioned this pull request Dec 30, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @jmikola