Skip to content

PHPC-529: Prefix BSON functions to avoid symbol conflicts #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2016
Merged

PHPC-529: Prefix BSON functions to avoid symbol conflicts #194

merged 1 commit into from
Jan 6, 2016

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jan 1, 2016

@jmikola jmikola mentioned this pull request Jan 4, 2016
Closed
@derickr
Copy link
Contributor

derickr commented Jan 4, 2016

LGTM, except for the outstanding question on PHONGO_API.

@jmikola
Copy link
Member Author

jmikola commented Jan 6, 2016

We'll sort out the PHONGO_API stuff in PHPC-533 and PHPC-532. In the meantime, this is merely adding the macro to the implementations because it was already in use in the header file, so I think it's fine as-is (given the scope of the issue).

@jmikola jmikola merged commit 24ed832 into mongodb:master Jan 6, 2016
jmikola added a commit that referenced this pull request Jan 6, 2016
@jmikola
Merge pull request #194
da1f707
@jmikola jmikola deleted the phpc-529 branch January 6, 2016 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikola @derickr