PHPC-593, PHPC-594, PHPC-595: Range checks for WriteConcern, Binary, and Timestamp #243
Conversation
jmikola
force-pushed
the
phpc-593-594-595
branch
from
b00e095 to
e02733b
Compare
| @@ -0,0 +1,40 @@ | |||
| --TEST-- | |||
| BSON BSON\Timestamp constructor requires positive 64-bit integers <= UINT32_MAX | |||
There was a problem hiding this comment.
why does the title say positive 64-bit integers <= UNIT32_MAX? Surely, you could just say:
requires positive unsigned 32-bit integers
There was a problem hiding this comment.
I believe I wanted to differentiate here because we do allow negative 32-bit integers (on 32-bit platforms), since we cast them to unsigned. The BSON timestamp type's two components are unsigned 32-bit integers. If we didn't cast 32-bit integers, we'd limit input to 2147483647 instead of 4294967295. I realize this is tricky and requires some documentation on PHP.net, but it seemed most flexible.
Anywho, only 64-bit integers are required to be positive, since we leave them as signed. How about:
requires 64-bit integers to be positive unsigned 32-bit integers
|
Besides the comment about the test case, this LGTM. The HHVM equivalent PR is mongodb/mongo-hhvm-driver#69 |
jmikola
force-pushed
the
phpc-593-594-595
branch
2 times, most recently
from
87055a8 to
d1b883c
Compare
This also defines a compatility constant for printing phongo_long, which may vary by PHP version and architecture.
This adds range checking to Timestamp's constructor and changes Timestamp::__toString() to print the components as unsigned 32-bit integers. Internal structs and functions were changed to use uint32_t for readability. 32-bit platforms will be limited to the range of signed 32-bit integers, since PHP has no unsigned integer type. This will be documented in PHPC-599.
This adds range checking to Binary's constructor. Internal structs and functions were changed to use uint8_t for readability.
jmikola
force-pushed
the
phpc-593-594-595
branch
from
d1b883c to
9f93fbd
Compare
This PR depends on #241 (i.e. PHPC-544).
https://jira.mongodb.org/browse/PHPC-593
https://jira.mongodb.org/browse/PHPC-594
https://jira.mongodb.org/browse/PHPC-595