Fixed PHPC-506: Use more descriptive messages in WriteExceptions #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
force-pushed
the
PHPC-506-more-descriptive-message-in-WriteExceptions
branch
3 times, most recently
from
b79e7be to
056be36
Compare
derickr
force-pushed
the
PHPC-506-more-descriptive-message-in-WriteExceptions
branch
from
056be36 to
5c366ee
Compare
| } | ||
|
|
||
| if (bson_iter_init_find(&inner_iter, &cbson, "errmsg") && BSON_ITER_HOLDS_UTF8(&inner_iter)) { | ||
| char *tmp_errmsg = bson_iter_dup_utf8(&inner_iter, NULL); |
There was a problem hiding this comment.
Any reason we can't simply use bson_iter_utf8() here, since tmp_errmsg is not going to be modified and we're just going to copy it into tmp_msg?
There was a problem hiding this comment.
No reason whatsoever - I didn't know it existed :-)
jmikola
added a commit
that referenced
this pull request
Mar 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-506