PHPC-633: Add SSL/SASL support to phpinfo() output #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2583,6 +2583,16 @@ PHP_MINFO_FUNCTION(mongodb) | |||
| #else | |||
| /* Bundled libraries, buildtime = runtime */ | |||
| php_info_print_table_row(2, "libmongoc version", MONGOC_VERSION_S); | |||
| # if HAVE_MONGOC_SSL | |||
There was a problem hiding this comment.
I'd suggest using the mongoc defines for this instead: MONGOC_ENABLE_SSL, MONGOC_ENABLE_SASL.
This should be updated later to print out with ssl lib it is using, maybe add a note to PHPC-542 ?
There was a problem hiding this comment.
These constants were not defined in the .h files that I needed it to be in:
src/libmongoc/src/mongoc/mongoc-config.h:#define MONGOC_ENABLE_SSL 1
win32/mongoc-config.h:#define MONGOC_ENABLE_SSL 1
And I don't want to expose vendored library's defines outside of it. Having specific defines for them makes for a cleaner separation.
There was a problem hiding this comment.
So when compiling against system mongoc these well say no sasl and ssl support.
That doesn't look right.
derickr
force-pushed
the
PHPC-633-phpinfo-sasl
branch
from
efbd670 to
fe63b15
Compare
|
Looks like I meant PHPC-633 |
jmikola
changed the title
|
See #498. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.