PHPC-554: Rephrase unsupported/corrupt BSON messages #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * been thrown already (due to an unsupported BSON type for example, | ||
| * don't overwrite with a generic exception message. */ | ||
| if (!EG(exception)) { | ||
| phongo_throw_exception(PHONGO_ERROR_UNEXPECTED_VALUE TSRMLS_CC, "Detected corrupt BSON data."); |
There was a problem hiding this comment.
I realize you used the same message in mongodb/mongo-hhvm-driver@1d51fe9, but should there really be a period after this message? We typically don't use that, and only did so in the corruption message since it consists of two sentences.
|
LGTM apart from the question on the exception message format. |
derickr
force-pushed
the
PHPC-554-unsupported-corrupt-bson
branch
from
324e242 to
a04008e
Compare
derickr
added a commit
that referenced
this pull request
Apr 25, 2016
| @@ -35,13 +35,13 @@ foreach ($tests as $bson) { | |||
| <?php exit(0); ?> | |||
| --EXPECTF-- | |||
| OK: Got MongoDB\Driver\Exception\UnexpectedValueException | |||
| Could not convert BSON document to a PHP variable | |||
| Detected corrupt BSON data. | |||
There was a problem hiding this comment.
I believe you forgot to remove the trailing period in these expected exception messages. Fixed in e6deaeb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-554