Move php_phongo_new_datetime_from_utcdatetime() into UTCDateTime.c #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't mind the function being moved, but I do not agree to the inlining of its contents. And, from what I understood, PRId64, is C99 only. I am not sure if that's what PHP's base line is. |
I didn't see the point for just a few lines of code that is only used in one method.
We already use EDIT: libmongoc is C89. They do define these macros if needed, though. |
|
LGTM |
This function was only used by UTCDateTime::toDateTime(), so it does not need to be in php_phongo.c. Additionally, this commit removes the platform-specific spprintf patterns in favor of the portable PRId64 pattern.
jmikola
force-pushed
the
1.1-UTCDateTime-toDateTime-refactor
branch
from
a9a2291 to
0d0b14b
Compare
jmikola
added a commit
that referenced
this pull request
Jun 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was only used by UTCDateTime::toDateTime(), so it does not need to be in php_phongo.c. Additionally, this commit removes the platform-specific spprintf patterns in favor of the portable PRId64 pattern.
This PR depends on #338.