PHPC-754 replace libmongoc-priv with libmongoc #357
Closed
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if $PKG_CONFIG libmongoc-1.0 --atleast-version 1.3.3; then | ||
| LIBMONGOC_INC=`$PKG_CONFIG libmongoc-priv --cflags` |
There was a problem hiding this comment.
Wouldn't --atleast-version 1.3.3 need to be changed to 1.4.0?
Are there similar changes required for the libbson package dependency? I expect they need to be kept in sync.
There was a problem hiding this comment.
libbson never had -priv, so no, thats not needed.
Good spot on --atleast-version 1.3.3 should be bumped to 1.4.0 if you decide on making that the minimum version.
We did not try to compile current php master against 1.3.3 as it currently declares as its minimum. I guess that is not correct today before or after this patch.
Before this patch, you cannot build against system mongoc 1.4, even though you do seem to require it.
|
Folding this into #362. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-754