Skip to content

PHPC-755 replace mongoc-trace with mongoc #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

puppyofkosh
Copy link
Contributor

@puppyofkosh puppyofkosh commented Jul 25, 2016

@bjori
Copy link
Contributor

bjori commented Jul 26, 2016

This is failing on travis:
https://travis-ci.org/mongodb/mongo-php-driver/jobs/147318803#L1239

/home/travis/build/mongodb/mongo-php-driver/php_phongo.c:1189:2: error: ‘ENTRY’ undeclared (first use in this function)
/home/travis/build/mongodb/mongo-php-driver/php_phongo.c:1189:2: note: each undeclared identifier is reported only once for each function it appears in
/home/travis/build/mongodb/mongo-php-driver/php_phongo.c:1207:4: error: implicit declaration of function ‘RETURN’ [-Werror=implicit-function-declaration]
/home/travis/build/mongodb/mongo-php-driver/php_phongo.c: In function ‘php_phongo_make_mongo_client’:
/home/travis/build/mongodb/mongo-php-driver/php_phongo.c:1894:2: error: ‘ENTRY’ undeclared (first use in this function)
/home/travis/build/mongodb/mongo-php-driver/php_phongo.c:1996:1: error: no return statement in function returning non-void [-Werror=return-type]

This is because this header is incorrectly required to be included in previous mongoc master.
This has been fixed in mongoc master so phongo just needs to bump its submodule.

However, bumping the submodule hits other unrelated failures, mostly due to configuration related things (e.g. missing things in mongoc-config.h, missing PHP_ADD_SOURCES etc).

When the submodule is bumped, you will no longer be able to include mongoc-log.h like this though, hence the PR. See https://jira.mongodb.org/browse/CDRIVER-1408

@jmikola
Copy link
Member

jmikola commented Jul 29, 2016

Folding this into #362.

@jmikola jmikola closed this Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants