PHPC-757: Implement The MongoDB Handshake Protocol #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1390,8 +1390,6 @@ static mongoc_client_t *php_phongo_make_mongo_client(const mongoc_uri_t *uri, zv | |||
| const char *mongoc_version, *bson_version; | |||
| mongoc_client_t *client; | |||
|
|
|||
| ENTRY; | |||
There was a problem hiding this comment.
I assume php_phongo_make_mongo_client() was the only use of libmongoc tracing in PHPC. Is that correct?
There was a problem hiding this comment.
Yes. As this was the only file that failed to compile now @bjori made it not leak.
derickr
force-pushed
the
PHPC-757-handshake
branch
from
cb6570a to
46b5019
Compare
derickr
force-pushed
the
PHPC-757-handshake
branch
from
bdbb14c to
e2f72f2
Compare
|
LGTM once the appended metadata suffix is freed. |
derickr
force-pushed
the
PHPC-757-handshake
branch
from
e2f72f2 to
91aaf65
Compare
jmikola
added a commit
that referenced
this pull request
Aug 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-757