PHPC-731: Parse Timestamp argument as strings to accept large integers #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
force-pushed
the
PHPC-731-timestamp-parse-as-string
branch
3 times, most recently
from
3d7caec to
f1c3c10
Compare
| @@ -0,0 +1,39 @@ | |||
| --TEST-- | |||
| MongoDB\BSON\Timestamp constructor requires 64-bit integers to be positive unsigned 32-bit integers (as string) | |||
There was a problem hiding this comment.
Unlike the 003 and 004 tests, these are only using string types. It doesn't make sense to refer to 64-bit integers or restrict the test to 64-bit platforms.
Both of these test cases should just be added into bson-timestamp-005.phpt, especially because we do want to test that the full range of 32-bit unsigned integers can be expressed on a 32-bit platform.
derickr
force-pushed
the
PHPC-731-timestamp-parse-as-string
branch
from
f1c3c10 to
01e8e81
Compare
|
All updated. |
|
LGTM. |
derickr
force-pushed
the
PHPC-731-timestamp-parse-as-string
branch
from
01e8e81 to
ff00668
Compare
derickr
added a commit
that referenced
this pull request
Sep 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PHPC-726/PR #386