PHPC-313: BSON should throw when encountering 64-bit integer on 32-bit platform #436
+47
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
previously requested changes
Oct 13, 2016
| tmp_len = spprintf(&tmp, 0, "%lld", value); \ | ||
| ADD_INDEX_STRINGL(zval, index, tmp, tmp_len); \ | ||
| efree(tmp); \ | ||
| phongo_throw_exception(PHONGO_ERROR_INVALID_ARGUMENT TSRMLS_CC, "Integer overflow detected on your platform: %lld", value); \ |
There was a problem hiding this comment.
There is little value in continuing to call mongoc_log() if we're throwing a proper exception.
There was a problem hiding this comment.
OK, will remove it.
| ]; | ||
|
|
||
| foreach ($tests as $json) { | ||
| throws(function() use ($json) { var_dump(toPHP(fromJSON($json))); }, 'MongoDB\Driver\Exception\InvalidArgumentException'); |
There was a problem hiding this comment.
This appears to be a tab. PHPT tests should be using 4-space indents.
There was a problem hiding this comment.
whatever. I'd rather see .c and .h files following coding standards though. phongo_compat.h is all spaces...
| echo "\n"; | ||
| } | ||
|
|
||
| ?> | ||
| ===DONE=== | ||
| <?php exit(0); ?> | ||
| --EXPECTF-- | ||
| %a |
There was a problem hiding this comment.
Per my earlier comment about mongoc_log() being useless, I think we should remove this and the --INI-- block.
derickr
force-pushed
the
PHPC-313-bson-64bit-on-32bit-platform
branch
from
8763aa3 to
22a39d6
Compare
derickr
added a commit
that referenced
this pull request
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.