Skip to content

PHPC-255 and PHPC-282: Do not allow multiple Cursor iterators or rewinds #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2015
Merged

PHPC-255 and PHPC-282: Do not allow multiple Cursor iterators or rewinds #44

merged 4 commits into from
May 4, 2015

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented May 4, 2015

jmikola added 2 commits May 4, 2015 16:15
@jmikola
PHPC-284: Create MongoDB\Driver\Exception\LogicException class
5bf6e2c
@jmikola
PHPC-282: Cursor should not yield multiple iterators
4e7df72 
Successive get_iterator handler invocations should throw a LogicException. This avoids situations that might allow the user to iterate over the same cursor multiple times.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 95d1ed8 on jmikola:phpc-255 into * on 10gen-labs:master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 95d1ed8 on jmikola:phpc-255 into * on 10gen-labs:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 95d1ed8 on jmikola:phpc-255 into * on 10gen-labs:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 95d1ed8 on jmikola:phpc-255 into * on 10gen-labs:master*.

@jmikola jmikola changed the title [WIP] PHPC-255 and PHPC-282: Do not allow multiple Cursor iterators or rewinds PHPC-255 and PHPC-282: Do not allow multiple Cursor iterators or rewinds May 4, 2015
@jmikola
Copy link
Member Author

jmikola commented May 4, 2015

This removes the segfault test from PHPC-239; however, I believe that bug was specific to a Cursor yielding multiple iterators.

@bjori
Copy link
Contributor

bjori commented May 4, 2015

lgtm

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 04d589b on jmikola:phpc-255 into * on 10gen-labs:master*.

jmikola added a commit that referenced this pull request May 4, 2015
@jmikola
Merge pull request #44 from jmikola/phpc-255
b0519cb 
PHPC-255 and PHPC-282: Do not allow multiple Cursor iterators or rewinds
@jmikola jmikola merged commit b0519cb into mongodb:master May 4, 2015
@jmikola jmikola deleted the phpc-255 branch May 4, 2015 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikola @coveralls @bjori