Skip to content

PHPC-718: Define extension dependencies #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Nov 7, 2016

https://jira.mongodb.org/browse/PHPC-718

Note: #454 (for PHPC-459) adds a dependency on the "json" extension.

Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't it rather be the other way around? PR 454 depending on this one - with this change happening first?

@jmikola
Copy link
Member Author

jmikola commented Nov 8, 2016

LGTM, but shouldn't it rather be the other way around? PR 454 depending on this one - with this change happening first?

Perhaps, although it doesn't make much difference. Seemed odd to list the dep before we introduce code to use it.

Is it worth scouting through our headers to see if there are other extensions we use? I know that we depend on class entries for date, json, and spl, and there are a fair number of standard functions that we use, but I didn't do an exhaustive search.

@jmikola jmikola force-pushed the phpc-718 branch 3 times, most recently from 1c619f8 to 4db911d Compare November 8, 2016 18:12
@jmikola
Copy link
Member Author

jmikola commented Nov 8, 2016

Is it worth scouting through our headers to see if there are other extensions we use? I know that we depend on class entries for date, json, and spl, and there are a fair number of standard functions that we use, but I didn't do an exhaustive search.

Just confirmed that all date, json, spl, and standard are the only extensions with headers that we include.

I also amended this PR to not include commits from #454.

@derickr
Copy link
Contributor

derickr commented Nov 16, 2016

LGTM

@jmikola jmikola merged commit 342b7de into mongodb:master Nov 16, 2016
jmikola added a commit that referenced this pull request Nov 16, 2016
@jmikola jmikola deleted the phpc-718 branch November 16, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants